feat(): Adding views for service accounts, ensuring user default view honored #17187
feat(): Adding views for service accounts, ensuring user default view honored #17187jjoyce0510 merged 6 commits intomasterfrom
Conversation
…' into jj--add-service-account-views-oss
|
Linear: CAT-1870 |
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (69.62%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. 📢 Thoughts on this report? Let us know! |
…' into jj--add-service-account-views-oss
|
🔴 Meticulous spotted visual differences in 10 of 1443 screens tested: view and approve differences detected. Meticulous evaluated ~10 hours of user flows against your PR. Last updated for commit |
|
Review: Smoke Test Analysis ( ✅ What's done well:
Verdict: The test coverage logic is good — the set/clear lifecycle is well thought out. The retry gap is the most actionable fix before merge to avoid flakiness in CI. |
shirshanka
left a comment
There was a problem hiding this comment.
Test improvement comments from Otto seem relevant. Take a look and see if its a quick improvement.
Stamping to unblock.
Bundle ReportChanges will increase total bundle size by 2.19kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
…' into jj--add-service-account-views-oss
Summary
In this PR, we add support for defining default views for Service Accounts. In addition, we align agent context kit with DataHub Cloud with respect to handling default view injection. Now we inject the user's PERSONAL default view first if one exists, otherwise fall back to the global org default (if the view resolution env variable is true)
Status
Ready for review.