feat(ingest/sigma): add formula bracket-ref extractor utility#17195
Open
kyungsoo-datahub wants to merge 3 commits intomasterfrom
Open
feat(ingest/sigma): add formula bracket-ref extractor utility#17195kyungsoo-datahub wants to merge 3 commits intomasterfrom
kyungsoo-datahub wants to merge 3 commits intomasterfrom
Conversation
Pure regex-based extraction of references from Sigma formula strings. Handles the escape (verified live across ~150 real workbook formulas) and parameter refs. Consumed by the upcoming DM-element FGL resolver (T1.RESOLVE-A) and chart InputFields fix; landing standalone for review isolation.
Contributor
|
Linear: ING-2455 |
github-actions
Bot
added
the
ingestion
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Connector Tests ResultsAll connector tests passed for commit To skip connector tests, add the Autogenerated by the connector-tests CI pipeline. |
maggiehays
added
the
needs-review
…rser Bracket refs inside double-quoted string literals (e.g. "[failed]") are not column references and must not produce lineage edges. Add _STRING_LITERAL_RE + _strip_string_literals() to blank out string literal spans before the bracket scan, preserving string length for positional debugging. Add two regression tests: the reviewer's exact example (If([status] = "FAILURE", "[failed]", [fallback]) -> 2 refs) plus an escaped-quote case.
maggiehays
added
pending-submitter-merge
and removed
needs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a small, standalone utility module that extracts
[Source/Column]bracket references from Sigma formula strings — the foundational piece
needed by the Sigma column-level-lineage program.