Render WMS previews for geoserver connected resources#30
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedFailed to post review comments 📝 WalkthroughWalkthroughThis PR implements comprehensive accessibility improvements, localization enhancements, and OGC map preview support. Changes include semantic HTML restructuring, lang attribute support for multilingual content, expanded i18n keys, new OGC service handling utilities, and ARIA attributes. Dark mode CSS was removed. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Browser
participant ResourcePreview
participant OgcService as OGC Service<br/>(WMS/WFS)
participant SldLoader as SLD Loader
participant LeafletMap
User->>Browser: Request map preview
Browser->>ResourcePreview: Render component
ResourcePreview->>ResourcePreview: getOgcPreviewConfig(resource)
alt Has OGC Preview
ResourcePreview->>ResourcePreview: Extract styleUrl for WFS
ResourcePreview->>OgcService: Fetch normalized OGC URL
OgcService-->>ResourcePreview: Return service response
alt styleUrl provided
ResourcePreview->>SldLoader: Load SLD from styleUrl
SldLoader->>SldLoader: Fetch & parse XML
SldLoader-->>ResourcePreview: SLD styling rules
ResourcePreview->>LeafletMap: Apply SLD styling to features
else No SLD
ResourcePreview->>LeafletMap: Render with default styling
end
else No OGC Preview
ResourcePreview->>Browser: Render static preview
end
LeafletMap-->>Browser: Display interactive map
Browser-->>User: Show map with applied styles
sequenceDiagram
participant Page as Dataset Page
participant CkanTranslations
participant PageHero
participant Browser
Page->>CkanTranslations: getLocalizedTextWithLang(title_translated, locale)
CkanTranslations-->>Page: {text, lang}
Page->>Page: Compute titleLang & descriptionLang
Page->>PageHero: Pass title, description, titleLang, descriptionLang
PageHero->>PageHero: Render h1 with lang={titleLang}
PageHero->>PageHero: Render description div with lang={descriptionLang}
PageHero-->>Browser: HTML with lang attributes
Browser->>Browser: Screen reader announces language
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mpolidori
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes & Improvements
Documentation