Fix headless MPEG-TS timestamps to use encoder-managed PTS#852
Merged
Conversation
The TS streamer was using wall-clock time for video PTS, causing DTS collisions and non-monotonic timestamp warnings when the pipeline produces frames faster than realtime. Remove explicit wall-clock PTS assignment and let the encoder auto-assign from the stream rate, matching the headless MP4 recorder behavior. Also fix cleanup routine. Signed-off-by: Josh Allmann <joshua.allmann@gmail.com> Made-with: Cursor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 fal.ai Preview Deployment
Livepeer Runner
Testing Livepeer Mode |
leszko
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this since #851 seems to have somehow gotten merged a little early while I was still testing.
The TS streamer was using wall-clock time for video PTS, causing DTS collisions and non-monotonic timestamp warnings when the pipeline produces frames faster than realtime. Remove explicit wall-clock PTS assignment and let the encoder auto-assign from the stream rate, matching the headless MP4 recorder behavior.
Also fix the cleanup routine to prevent hangs sometimes.
Made-with: Cursor