fix: refresh workflow builder pipelines after cloud connect#853
Merged
Conversation
When the LTX plugin is preinstalled in the cloud, connecting to cloud didn't reliably update the graph editor's pipeline dropdown because: 1. The backend's _pipeline_schemas_cache could serve stale local-only data if a request slipped through during the cloud connection transition. Invalidate the cache on cloud connect/disconnect. 2. PipelinesContext.refreshPipelines() only bumped pipelinesVersion on success. If the fetch failed (e.g. cloud proxy momentarily unavailable), the version counter never incremented, so the graph editor's useGraphState effect never got a second trigger to re-fetch. Move the version bump to a finally block so dependent effects always get a chance to retry. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Rafał Leszko <rafal@livepeer.org>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 fal.ai Preview Deployment
Livepeer Runner
Testing Livepeer Mode |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_pipeline_schemas_cacheon cloud connect/disconnect so stale local-only pipeline data is never served during the connection transitionpipelinesVersionbump to afinallyblock inPipelinesContext.refreshPipelines()so the graph editor'suseGraphStateeffect always gets a re-fetch trigger, even if the initial refresh failed during cloud proxy establishmentFixes the bug where the LTX-2 pipeline (preinstalled in cloud) didn't appear in the workflow builder's pipeline dropdown until the page was refreshed.
Test plan
Generated with Claude Code