fix: default pathOptional to '/' when deregistering root optional params#423
Open
deepview-autofix wants to merge 1 commit into
Open
fix: default pathOptional to '/' when deregistering root optional params#423deepview-autofix wants to merge 1 commit into
deepview-autofix wants to merge 1 commit into
Conversation
The `off` method replaced the optional parameter in the path but did not fall back to '/' when the resulting string was empty, unlike `on`. For paths like `/:param?`, `off` threw "The path could not be empty" instead of removing the route registered at '/'. Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: DeepView Autofix <276251120+deepview-autofix@users.noreply.github.com> Co-Authored-By: Nikita Skovoroda <chalkerx@gmail.com> Signed-off-by: Nikita Skovoroda <chalkerx@gmail.com>
ChALkeR
reviewed
Apr 19, 2026
ChALkeR
left a comment
ChALkeR
left a comment
There was a problem hiding this comment.
the test was throwing on findMyWay.off('GET', '/:optional?') before the fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
offmethod replaced the optional parameter in the path but did not fall back to '/' when the resulting string was empty, unlikeon. For paths like/:param?,offthrew "The path could not be empty" instead of removing the route registered at '/'.