Add Triage and Review team charter. #79
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,64 @@ | ||||||
| # Triage and Review Team | ||||||
|
|
||||||
| The Triage & Review Team assists with the processing of pull requests, bug reports, and feature requests. Members of this team are contributors who regularly step up to help with the invisible work of maintaining the Django framework. | ||||||
|
|
||||||
| ## Scope of responsibilities | ||||||
|
|
||||||
| The objective of the team is to help spread work beyond the [Mergers](https://www.djangoproject.com/foundation/teams/#mergers-team) and into the wider contributor community. The team has elevated permissions in Trac and GitHub to allow them to triage and maintain tickets and pull requests. A pull request approval from a member of the Triage and Review team allows a Merger to merge a minor change that they, themselves have primarily authored. | ||||||
|
|
||||||
| Team members will: | ||||||
|
|
||||||
| - Triage tickets according to the [documented process](https://docs.djangoproject.com/en/dev/internals/contributing/triaging-tickets/). | ||||||
| - Review patches to ensure they adhere to the [documented guidelines](https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-patches/#patch-review-checklist). | ||||||
| - Monitor active contributors to invite as Triage & Review team members. | ||||||
|
|
||||||
| ## Initial membership | ||||||
|
|
||||||
| - Chair: | ||||||
| - Co-Chair: | ||||||
| - Steering Council Liaison (must be an active Steering Council member; may be the same as Chair/Co-Chair): | ||||||
| - Other members: | ||||||
|
tim-schilling marked this conversation as resolved.
|
||||||
| - Clifford Gama | ||||||
| - David Sanders | ||||||
| - David Smith | ||||||
| - Hasan Ramezani | ||||||
|
jacobtylerwalls marked this conversation as resolved.
|
||||||
| - Jacob Walls | ||||||
| - JaeHyuck Sa | ||||||
| - Lilian Tran | ||||||
| - Lily Foote | ||||||
| - Mariusz Felisiak | ||||||
| - Natalia Bidart | ||||||
| - Nick Pope | ||||||
| - Sarah Boyce | ||||||
| - SiHyunLee | ||||||
| - Simon Charette | ||||||
|
|
||||||
|
|
||||||
| ## Future membership | ||||||
|
|
||||||
| Anyone actively engaging in discussions on [GitHub](https://github.com/django), the [Forum](https://forum.djangoproject.com/) and/or the [new-features repository](https://github.com/django/new-features) will be eligible to join the Triage and Review Team. | ||||||
|
|
||||||
| The membership will operate as follows: | ||||||
| - Any existing member can invite an active contributor to join the team | ||||||
|
Member
There was a problem hiding this comment. Although this is already captured on the wiki (“Once there is agreement from the team that the new member is suitable to join”), restating it in the charter that team consensus is required before member invitations would improve clarity. It would also be useful to specify the approval threshold or percentage required for acceptance.
Member
Author
There was a problem hiding this comment.
Suggested change
Consensus is defined as +2 in the team's wiki. I'm fine adding that here, but I suspect that's not how things work. @jacobtylerwalls I think you've added people recently, can you clarify this when you have time please?
Member
There was a problem hiding this comment. I can't locate which part of the wiki you mean. In my experience, nominations have been so careful that I've never seen a dissent. I've seen one set of nominations get stalled because it had several candidates, so the +1s rolled in separately. I'm actually going to resurrect that thread now. It's more like "any objections?"
Member
There was a problem hiding this comment. Sorry, that wasn't so clear. Yes I think the proposed "second" is fine.
Member
Author
There was a problem hiding this comment. |
||||||
| - Each year, every non-Fellow member will need to reaffirm their membership with the team | ||||||
|
|
||||||
| There are [instructions on how to add new members to the team in the Wiki](https://code.djangoproject.com/wiki/TriageReviewTeam#HowtoaddamembertotheTriageReviewTeam). | ||||||
|
|
||||||
| ## Budget | ||||||
|
|
||||||
| There is no budget, but requests can be made to the Board as needs arise. | ||||||
|
|
||||||
| Django has some professional PyCharm licenses that we can share with our contributors. Team members are eligible to receive these. | ||||||
|
Member
There was a problem hiding this comment. Are these licenses meant to be lifetime or time-limited? Both ways, adding a brief note that they are dependent on availability or subject to change would help set expectations, since access may not be guaranteed indefinitely. Additionally, "... share with our contributors" - here, contributors refer to the members of WG, right? We can mention that too explicitly.
Member
Author
There was a problem hiding this comment.
Can those details be handled by the team and/or board itself? I don't know if the charter needs to capture that level of detail.
No, I didn't meant that. Contributors is meant to be interpreted in a general sense beyond this team. Your concern regarding members of the WG should be covered by the following sentence: "Team members are eligible to receive these."
Member
Author
There was a problem hiding this comment. Whoops, I didn't answer your question! Sorry. I don't know the duration of those licenses.
Member
There was a problem hiding this comment. PyCharm renews them for "some time" based on goodwill; let's just keep it vague.
Member
There was a problem hiding this comment. Alright, thanks for the info.
Member
Author
There was a problem hiding this comment. @priyapahwa did you want to see changes here still? Not sure where we landed based on your response.
Member
There was a problem hiding this comment. I think we’re good to leave it as-is. Thanks for checking! |
||||||
|
|
||||||
| ## Comms | ||||||
|
|
||||||
| The team can be mentioned in the following ways: | ||||||
| - [GitHub team](https://github.com/orgs/django/teams/triage-review) | ||||||
|
|
||||||
| The team communicates on the following channels: | ||||||
| - [Mailing list](https://groups.google.com/a/djangoproject.com/g/triage-review/members) | ||||||
| - [Private Discord `#triage-review` channel](https://chat.djangoproject.com/) | ||||||
|
|
||||||
| ## Reporting | ||||||
|
|
||||||
| The team does not produce reports at this time. | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few notes on this paragraph, maybe no change is needed but I figured I'd mention this:
ccin a ticket which a regular user can't, but that's all)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the broad statement of "The team has elevated permissions in Trac and GitHub" covers both of those cases (being able to CC someone is an elevated permission). I'm not sure we should list the permissions explicitly in this document. The benefit of not having the explicit permissions listed is that we're more flexible if there are permission changes in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Tim, the team can also close duplicate/nuisance PRs, too, which is great, but doesn't need to go in the charter.