fix: scd2 unmapped insert for nested tables#3812
Open
deschman wants to merge 2 commits intodlt-hub:develfrom
Open
fix: scd2 unmapped insert for nested tables#3812deschman wants to merge 2 commits intodlt-hub:develfrom
scd2 unmapped insert for nested tables#3812deschman wants to merge 2 commits intodlt-hub:develfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For nested tables loaded with the
scd2merge strategy, the follow-up SQL that inserts new rows from the staging table into the destination usedINSERT INTO … SELECT *. That ties column order to whatever the bulk writer produced in staging. On Spark/Databricks (ANSI mode), if staging and destination disagree on a column’s type—e.g. schema drift or evolving JSON—SELECT *can produce values that do not assign cleanly to the target table and surfaces as obscureDATATYPE_MISMATCHerrors.This change generates an explicit column list from the destination table schema (excluding the SCD2
from/tometadata columns) for both theINSERTtarget list and theSELECT, so values are aligned by column name with the destination DDL instead of by staging column order.Related Issues
scd2nested table inserts are nondeterministic #3811Additional Context
SELECT *pattern.make test-commonlocally and the suite was green.