Update LocationInput struct to use omitempty for optional fields#29
Merged
donseba merged 2 commits intodonseba:mainfrom Mar 29, 2026
Merged
Update LocationInput struct to use omitempty for optional fields#29donseba merged 2 commits intodonseba:mainfrom
donseba merged 2 commits intodonseba:mainfrom
Conversation
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the LocationInput JSON serialization so optional fields are omitted from the HX-Location header payload, matching the intent of not emitting non-required fields.
Changes:
- Add
omitemptyJSON tags to optional fields onLocationInput. - Update
TestNewto assert the expected minimal JSON payload forHX-Location.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| handler.go | Marks optional LocationInput fields with omitempty so empty values aren’t serialized into HX-Location. |
| htmx_test.go | Adds an assertion to verify the HX-Location JSON output omits empty optional fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
donseba
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not serialize non required field in hx-location header