Refactor _check_chat_template method to improve tokenizer compatibility checks#1855
Open
Ki-Seki wants to merge 1 commit intodottxt-ai:mainfrom
Open
Refactor _check_chat_template method to improve tokenizer compatibility checks#1855Ki-Seki wants to merge 1 commit intodottxt-ai:mainfrom
Ki-Seki wants to merge 1 commit intodottxt-ai:mainfrom
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@RobinPicard Could you take a look at my PR and review it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1854
This PR removes strict type‑based checks against vLLM’s internal tokenizer classes (
PreTrainedTokenizer,PreTrainedTokenizerFast,TokenizerBase), which were removed or renamed in newer vLLM releases. Instead, the logic now uses capability‑based detection (hasattr+ safeapply_chat_templateinvocation), ensuring compatibility across:TokenizerLikeinterface)apply_chat_templateexists)This makes Outlines robust to upstream API changes and eliminates fragile imports from vLLM internals.
🚧 Thank you for opening a PR!
A few important guidelines and requirements before we can merge your PR:
maincommit;pre-commitis installed and configured on your machine, and you ran it before opening the PR;Consider opening a Draft PR if your work is still in progress but you would
like some feedback from other contributors.