Compiler#visit_implication, Compiler#visit_intersection and a couple of changes in specs#452
Open
estum wants to merge 2 commits intodry-rb:mainfrom
Open
Compiler#visit_implication, Compiler#visit_intersection and a couple of changes in specs#452estum wants to merge 2 commits intodry-rb:mainfrom
estum wants to merge 2 commits intodry-rb:mainfrom
Conversation
Probably, their were simply copied from a sum spec and so weren't relevant to the target classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1st part of the PR adds missing visitor methods to Compiler and also adds examples for composite types to its spec.
And I also noticed in implication & intersection specs messing examples describing "#meta", probably were copy-pasted from sum_spec.rb and left as is. Sum#meta behaviour is defined explicitly and differs from the other composite types, so this PR fixes it.