Open
Conversation
jaromil
force-pushed
the
origin/shakeoscillate
branch
2 times, most recently
from
ff2e225 to
facfe48
Compare
rrrapha
suggested changes
Jun 15, 2025
|
|
||
| } | ||
|
|
||
| void clearScreen(cairo_t* cr, int width, int height) { |
Contributor
There was a problem hiding this comment.
Parameters width and height are unused in this function and can be removed.
|
|
||
| private: | ||
|
|
||
| unsigned int width; |
Contributor
There was a problem hiding this comment.
It is not necessary to declare width and height here, see frei0r.hpp.
| register_param(this->phase, "phase", "The phase of the sin and cos functions of this effect."); | ||
| register_param(this->mirrored, "mirrored", "On/Off Image Mirror Extend"); | ||
|
|
||
| this->width = width; |
Contributor
There was a problem hiding this comment.
width and height are already set in the parent constructor, no need to do this here.
jaromil
force-pushed
the
origin/shakeoscillate
branch
from
facfe48 to
a0ded73
Compare
jaromil
force-pushed
the
origin/shakeoscillate
branch
from
a0ded73 to
55d42f7
Compare
jaromil
force-pushed
the
origin/shakeoscillate
branch
from
55d42f7 to
a718fa6
Compare
Contributor
|
Thanks for working on this, |
|
Will this be made available soon? |
jaromil
force-pushed
the
origin/shakeoscillate
branch
from
a718fa6 to
00f5503
Compare
❌ Conventional Commits check failedOne or more commit messages in this PR do not follow the Invalid commits:
Expected format Examples
Please fix the commit messages (e.g. via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebase of PR #197 by @JohannJEG