Skip to content

Fix publishing#499

Merged
jreineckearm merged 5 commits into
eclipse-cdt-cloud:mainfrom
jreineckearm:fix-publishing
Feb 27, 2026
Merged

Fix publishing#499
jreineckearm merged 5 commits into
eclipse-cdt-cloud:mainfrom
jreineckearm:fix-publishing

Conversation

@jreineckearm
Copy link
Copy Markdown
Contributor

@jreineckearm jreineckearm commented Feb 26, 2026

  • Restrict permissions in workflows to what's needed.
  • Update CI to fulfill requirements for OIDC (node 22)
  • Removed NPM token from workflow and set permission id-token: write to enable OIDC.

Related EF IT helpdesk ticket to set up Trusted Publishing on three packages we maintain and that I am aware of:
https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/7195 (updated to an issue, was task before)

Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
@jreineckearm jreineckearm marked this pull request as ready for review February 26, 2026 10:44
@cwalther
Copy link
Copy Markdown
Contributor

Looks sensible at a glance, but I’m not familiar with the process, so I guess we’ll just have to see whether it works, and wait for feedback from the helpdesk.

Copy link
Copy Markdown
Contributor

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know the details here, but I am ok with the experiment.


VSCode is on Node 22 these days, so updating to Node 22 is fine by me. But I don't think we should hide it in here and instead make it explicit, for example in the README (this line)

If we stop build & test with node 20, I don't think we should spend too much time trying to support it going forward. Keeping our test matrix as small as possible would be best (and it is already big)

@jreineckearm
Copy link
Copy Markdown
Contributor Author

make it explicit, for example in the README

Thanks, forgot about the docs, will update.

Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
@jreineckearm
Copy link
Copy Markdown
Contributor Author

Updated cdt-gdb-vscode to node 22 for consistency as part of eclipse-cdt-cloud/cdt-gdb-vscode#200

@jreineckearm
Copy link
Copy Markdown
Contributor Author

Trusted publishing has been set up now. It should just work.... (famous last words).
Merging and giving it a try with a 1.7.1 release.

@jreineckearm jreineckearm merged commit d58fc54 into eclipse-cdt-cloud:main Feb 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants