Expose lookup version published_at#1586
Open
AgentGoose32 wants to merge 1 commit intoecosyste-ms:mainfrom
Open
Expose lookup version published_at#1586AgentGoose32 wants to merge 1 commit intoecosyste-ms:mainfrom
AgentGoose32 wants to merge 1 commit intoecosyste-ms:mainfrom
Conversation
Author
|
Update: I brought up local PostgreSQL and Redis and reran the targeted controller coverage.
Result: 3 runs, 10 assertions, 0 failures, 0 errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #644
Summary
published_atto lookup responses when a version is present and found.published_atwhen the requested version is not known.Validation
/opt/homebrew/opt/ruby/bin/bundle exec ruby -c app/controllers/api/v1/packages_controller.rb/opt/homebrew/opt/ruby/bin/bundle exec ruby -c app/views/api/v1/packages/lookup.json.jbuilder/opt/homebrew/opt/ruby/bin/bundle exec ruby -c test/controllers/api/v1/packages_controller_test.rbgit diff --checkNote: targeted Rails controller tests are blocked locally because PostgreSQL is not running on
/tmp/.s.PGSQL.5432.