ci: Version Packages#116
Open
github-actions[bot] wants to merge 1 commit intomainfrom
Open
Conversation
Reviewer's GuideAutomated Changesets release PR that publishes TanStack Query 5.100.9 / Svelte/Vue devtools 6.1.28, applying a type-safety fix in query-core, a devtools callback typing change, Angular floating devtools theme support, and propagating those changes across all framework bindings, example apps, and changelogs while cleaning up the processed changesets. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Important Review skipped Codemetrics is installed on this repository, but your organization doesn't have an account yet. Sign up free to enable AI code reviews, developer scorecards, DORA metrics, and more. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="packages/query-core/CHANGELOG.md" line_range="7" />
<code_context>
+
+### Patch Changes
+
+- fix(query-core): wrap `persister`'s `TQueryKey` in `NoInfer` so that the `persister` slot no longer contributes to `TQueryKey` inference. Follow-up to #10510, which removed `NoInfer` on all three `persister` generics. Preserving `NoInfer<TQueryKey>` keeps that fix's benefit for `TQueryFnData` while preventing `TQueryKey` from widening to the augmented constraint when `Register.queryKey` is narrowed — which made `DataTag`-branded wrapper returns un-assignable in contravariant slots. ([#10601](https://github.com/TanStack/query/pull/10601))
+
## 5.100.8
</code_context>
<issue_to_address>
**issue (typo):** Consider changing “un-assignable” to the more standard spelling “unassignable”.
Here, the hyphenated form “un-assignable” is nonstandard. Please update it to the standard spelling “unassignable” for consistency with modern technical writing.
```suggestion
- fix(query-core): wrap `persister`'s `TQueryKey` in `NoInfer` so that the `persister` slot no longer contributes to `TQueryKey` inference. Follow-up to #10510, which removed `NoInfer` on all three `persister` generics. Preserving `NoInfer<TQueryKey>` keeps that fix's benefit for `TQueryFnData` while preventing `TQueryKey` from widening to the augmented constraint when `Register.queryKey` is narrowed — which made `DataTag`-branded wrapper returns unassignable in contravariant slots. ([#10601](https://github.com/TanStack/query/pull/10601))
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| ### Patch Changes | ||
|
|
||
| - fix(query-core): wrap `persister`'s `TQueryKey` in `NoInfer` so that the `persister` slot no longer contributes to `TQueryKey` inference. Follow-up to #10510, which removed `NoInfer` on all three `persister` generics. Preserving `NoInfer<TQueryKey>` keeps that fix's benefit for `TQueryFnData` while preventing `TQueryKey` from widening to the augmented constraint when `Register.queryKey` is narrowed — which made `DataTag`-branded wrapper returns un-assignable in contravariant slots. ([#10601](https://github.com/TanStack/query/pull/10601)) |
There was a problem hiding this comment.
issue (typo): Consider changing “un-assignable” to the more standard spelling “unassignable”.
Here, the hyphenated form “un-assignable” is nonstandard. Please update it to the standard spelling “unassignable” for consistency with modern technical writing.
Suggested change
| - fix(query-core): wrap `persister`'s `TQueryKey` in `NoInfer` so that the `persister` slot no longer contributes to `TQueryKey` inference. Follow-up to #10510, which removed `NoInfer` on all three `persister` generics. Preserving `NoInfer<TQueryKey>` keeps that fix's benefit for `TQueryFnData` while preventing `TQueryKey` from widening to the augmented constraint when `Register.queryKey` is narrowed — which made `DataTag`-branded wrapper returns un-assignable in contravariant slots. ([#10601](https://github.com/TanStack/query/pull/10601)) | |
| - fix(query-core): wrap `persister`'s `TQueryKey` in `NoInfer` so that the `persister` slot no longer contributes to `TQueryKey` inference. Follow-up to #10510, which removed `NoInfer` on all three `persister` generics. Preserving `NoInfer<TQueryKey>` keeps that fix's benefit for `TQueryFnData` while preventing `TQueryKey` from widening to the augmented constraint when `Register.queryKey` is narrowed — which made `DataTag`-branded wrapper returns unassignable in contravariant slots. ([#10601](https://github.com/TanStack/query/pull/10601)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@tanstack/angular-query-experimental@5.100.9
Patch Changes
Add theme option support to Angular floating devtools. (#10609)
Updated dependencies [
fcee7bd]:@tanstack/preact-query@5.100.9
Patch Changes
fcee7bd]:@tanstack/preact-query-devtools@5.100.9
Patch Changes
3d21cac]:@tanstack/preact-query-persist-client@5.100.9
Patch Changes
@tanstack/query-async-storage-persister@5.100.9
Patch Changes
fcee7bd]:@tanstack/query-broadcast-client-experimental@5.100.9
Patch Changes
fcee7bd]:@tanstack/query-core@5.100.9
Patch Changes
persister'sTQueryKeyinNoInferso that thepersisterslot no longer contributes toTQueryKeyinference. Follow-up to fix(query-core): stop wrapping persister generics in NoInfer TanStack/query#10510, which removedNoInferon all threepersistergenerics. PreservingNoInfer<TQueryKey>keeps that fix's benefit forTQueryFnDatawhile preventingTQueryKeyfrom widening to the augmented constraint whenRegister.queryKeyis narrowed — which madeDataTag-branded wrapper returns un-assignable in contravariant slots. (#10601)@tanstack/query-devtools@5.100.9
Patch Changes
setOnClosecallback type to returnvoid. (#10607)@tanstack/query-persist-client-core@5.100.9
Patch Changes
fcee7bd]:@tanstack/query-sync-storage-persister@5.100.9
Patch Changes
fcee7bd]:@tanstack/react-query@5.100.9
Patch Changes
fcee7bd]:@tanstack/react-query-devtools@5.100.9
Patch Changes
3d21cac]:@tanstack/react-query-next-experimental@5.100.9
Patch Changes
@tanstack/react-query-persist-client@5.100.9
Patch Changes
@tanstack/solid-query@5.100.9
Patch Changes
fcee7bd]:@tanstack/solid-query-devtools@5.100.9
Patch Changes
3d21cac]:@tanstack/solid-query-persist-client@5.100.9
Patch Changes
@tanstack/svelte-query@6.1.28
Patch Changes
fcee7bd]:@tanstack/svelte-query-devtools@6.1.28
Patch Changes
3d21cac]:@tanstack/svelte-query-persist-client@6.1.28
Patch Changes
@tanstack/vue-query@5.100.9
Patch Changes
fcee7bd]:@tanstack/vue-query-devtools@6.1.28
Patch Changes
3d21cac]:@tanstack/eslint-plugin-query@5.100.9
@tanstack/angular-query-persist-client@5.100.9
Patch Changes
bf902df]:Summary by Sourcery
Release TanStack Query core, platform bindings, devtools, and persist/persister packages at versions 5.100.9 and 6.1.28, propagating the changes into example apps and cleaning up corresponding changesets.
New Features:
Bug Fixes:
Enhancements:
Chores: