remove the duplicate report config#431
Conversation
WalkthroughA duplicate build job declaration for "builds/urban/utilities/report" was removed from the YAML configuration file. The earlier instance of this job definition, which specified work-dir, image-name, and dockerfile properties, has been deleted, leaving the remaining instance as the sole definition. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
build/build-config.yml (1)
248-277:⚠️ Potential issue | 🟡 MinorOther duplicate build jobs remain in this file.
While the duplicate
builds/urban/utilities/reportentry was removed, two more duplicates still exist:
builds/urban/utilities/egov-searcher— declared at lines 242–246 and again at lines 264–268.builds/urban/utilities/egov-survey-services— declared at lines 254–260 and again at lines 271–277.Please remove these as well to complete the cleanup.
Proposed fix
- name: "builds/urban/utilities/report" build: - work-dir: "utilities/report" image-name: "report" dockerfile: "build/maven/Dockerfile" - - name: "builds/urban/utilities/egov-survey-services" - build: - - work-dir: "utilities/egov-survey-services" - image-name: "egov-survey-services" - dockerfile: "build/maven/Dockerfile" - - work-dir: "utilities/egov-survey-services/src/main/resources/db" - image-name: "egov-survey-services-db" - - - - name: "builds/urban/utilities/egov-searcher" - build: - - work-dir: "utilities/egov-searcher" - image-name: "egov-searcher" - dockerfile: "build/maven/Dockerfile" - - name: "builds/urban/utilities/egov-survey-services" build:
Summary by CodeRabbit