Skip to content

remove the duplicate report config#431

Open
priyanshu-egov wants to merge 1 commit into
masterfrom
report_service_patch
Open

remove the duplicate report config#431
priyanshu-egov wants to merge 1 commit into
masterfrom
report_service_patch

Conversation

@priyanshu-egov
Copy link
Copy Markdown
Collaborator

@priyanshu-egov priyanshu-egov commented Feb 11, 2026

Summary by CodeRabbit

  • Chores
    • Removed a duplicate build configuration to streamline the build setup.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 11, 2026

Walkthrough

A duplicate build job declaration for "builds/urban/utilities/report" was removed from the YAML configuration file. The earlier instance of this job definition, which specified work-dir, image-name, and dockerfile properties, has been deleted, leaving the remaining instance as the sole definition.

Changes

Cohort / File(s) Summary
Build Configuration
build/build-config.yml
Removed duplicate build job declaration for "builds/urban/utilities/report" containing work-dir, image-name, and dockerfile specifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A duplicate job once cluttered our build,
Now cleaned with precision, the file is distilled,
One report definition remains standing tall,
In the rabbit's garden of config, less is all! 🌱

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'remove the duplicate report config' directly and clearly summarizes the main change: removing a duplicate build job declaration for 'builds/urban/utilities/report' from the configuration file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch report_service_patch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
build/build-config.yml (1)

248-277: ⚠️ Potential issue | 🟡 Minor

Other duplicate build jobs remain in this file.

While the duplicate builds/urban/utilities/report entry was removed, two more duplicates still exist:

  1. builds/urban/utilities/egov-searcher — declared at lines 242–246 and again at lines 264–268.
  2. builds/urban/utilities/egov-survey-services — declared at lines 254–260 and again at lines 271–277.

Please remove these as well to complete the cleanup.

Proposed fix
  - name: "builds/urban/utilities/report"
    build:
      - work-dir: "utilities/report"
        image-name: "report"
        dockerfile: "build/maven/Dockerfile"  
        
-  - name: "builds/urban/utilities/egov-survey-services"
-    build:
-      - work-dir: "utilities/egov-survey-services"
-        image-name: "egov-survey-services"
-        dockerfile: "build/maven/Dockerfile"
-      - work-dir: "utilities/egov-survey-services/src/main/resources/db"
-        image-name: "egov-survey-services-db"
-                    
-        
 
-  - name: "builds/urban/utilities/egov-searcher"
-    build:
-      - work-dir: "utilities/egov-searcher"
-        image-name: "egov-searcher"
-        dockerfile: "build/maven/Dockerfile"
-
 
   - name: "builds/urban/utilities/egov-survey-services"
     build:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant