Skip to content

add setSync function, write user data sync.#66

Open
zhenshuaiwws wants to merge 1 commit intoelectron-userland:masterfrom
zhenshuaiwws:master
Open

add setSync function, write user data sync.#66
zhenshuaiwws wants to merge 1 commit intoelectron-userland:masterfrom
zhenshuaiwws:master

Conversation

@zhenshuaiwws
Copy link
Copy Markdown

When I want to save data before the app exits, but the set method does not complete before the end of the process, resulting in the data not saved successfully, so I need to save the data synchronously.

@jviotti
Copy link
Copy Markdown
Contributor

jviotti commented May 16, 2017

Hey there, thanks a lot for the contribution! Some comments:

  • Can we add tests for this new function?
  • Since this is a synchronous function, it shouldn't take a callback, but simply return the value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants