feat(comp, g4): Add COMP pin definitions and register enums#613
Draft
IvanLi-CN wants to merge 1 commit intoembassy-rs:mainfrom
Draft
feat(comp, g4): Add COMP pin definitions and register enums#613IvanLi-CN wants to merge 1 commit intoembassy-rs:mainfrom
IvanLi-CN wants to merge 1 commit intoembassy-rs:mainfrom
Conversation
Member
|
Please do not add enums for "0 = disabled, 1 = enabled", they're redundant. |
Add pin definitions for COMP1-7 in data/extra/family/STM32G4.yaml. Add enum definitions and link them in data/registers/comp_v2.yaml. Signed-off-by: Ivan Li <ivanli2048@gmail.com>
IvanLi-CN
force-pushed
the
feat/g4-comp-update
branch
from
e41202e to
b739554
Compare
Member
|
LOCK, SCALEN, BRGEN, EN enums should be deleted, they're redundant. |
Author
|
Sorry, I just noticed the notification email, please give me some time and I will correct the problem. At the moment I'm still trying to figure out what to do about embassy-stm32, when I make progress I'll change the code as you suggested and submit it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pin definitions for COMP1-7 in data/extra/family/STM32G4.yaml. Add enum definitions and link them in data/registers/comp_v2.yaml.