fix: stale HTTPRoute/GRPCRoute/TLSRoute/TCPRoute/UDPRoute status after gateway-only spec changes#8876
Open
yuehaii wants to merge 6 commits intoenvoyproxy:mainfrom
Open
fix: stale HTTPRoute/GRPCRoute/TLSRoute/TCPRoute/UDPRoute status after gateway-only spec changes#8876yuehaii wants to merge 6 commits intoenvoyproxy:mainfrom
yuehaii wants to merge 6 commits intoenvoyproxy:mainfrom
Conversation
…r gateway-only spec changes Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>
Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f6c48c111
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…edGeneration Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>
Signed-off-by: Hai <20416005+yuehaii@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix: stale HTTPRoute/GRPCRoute/TLSRoute/TCPRoute/UDPRoute/ status after gateway-only spec changes
Issue description
When a Gateway resource is updated without touching any Route resource (e.g. a listener hostname or allowedRoutes change), the Route's status.parents[*].conditions become stale, the observedGeneration field continues pointing at the old gateway generation instead of the new one.
Root cause
The bug only manifests as False→False (same outcome, only ObservedGeneration should advance). If the gateway update trigger a new route reconcile, GetGeneration() hasn't changed because the route was not modified. So the newly computed condition is byte-for-byte identical to what's already in the store and never trigger the status update.
Fix
Compute observedGeneration as the max of route and gateway generation at the top of each parentRef loop iteration, and use it only for gateway-driven conditions.
Verification
Which issue(s) this PR fixes:
Fixes #8861
Release Notes: Yes