Skip to content

README: fix extra whitespace in image credit line#21652

Open
goingforstudying-ctrl wants to merge 1 commit intoetcd-io:mainfrom
goingforstudying-ctrl:fix/readme-typo-whitespace
Open

README: fix extra whitespace in image credit line#21652
goingforstudying-ctrl wants to merge 1 commit intoetcd-io:mainfrom
goingforstudying-ctrl:fix/readme-typo-whitespace

Conversation

@goingforstudying-ctrl
Copy link
Copy Markdown
Contributor

Removes the extra space between 'to' and 'xkcd.com/2347' in the image credit line.

Fixes #21643

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: goingforstudying-ctrl
Once this PR has been reviewed and has the lgtm label, please assign ivanvc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown

Hi @goingforstudying-ctrl. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@goingforstudying-ctrl
Copy link
Copy Markdown
Contributor Author

Hi maintainers! This is a small whitespace fix in the README image credit line. The PR is clean and CI passes. Would appreciate a review when you have a moment. Thanks!

@goingforstudying-ctrl
Copy link
Copy Markdown
Contributor Author

Hi etcd maintainers,

This PR is a minimal whitespace fix in the README image credit line. The k8s-ci-robot is waiting for an command from an org member to run CI.

Could a maintainer please trigger the test with ? The change is very small and safe — just removes extra whitespace. Thanks!

@goingforstudying-ctrl goingforstudying-ctrl force-pushed the fix/readme-typo-whitespace branch 3 times, most recently from 4ba701f to 5a31066 Compare April 29, 2026 12:06
@goingforstudying-ctrl
Copy link
Copy Markdown
Contributor Author

Hi etcd maintainers! 👋 This is a minimal whitespace fix in the README image credit line. The k8s-ci-robot is waiting for an /ok-to-test command from an org member to run CI. Could someone please trigger the tests? It's a trivial change and should be quick to review. Thanks!

@goingforstudying-ctrl goingforstudying-ctrl force-pushed the fix/readme-typo-whitespace branch from 5a31066 to 03113ec Compare April 30, 2026 18:10
@goingforstudying-ctrl
Copy link
Copy Markdown
Contributor Author

Hi maintainers, just checking in on this PR. Please let me know if any changes are needed. Happy to address any feedback!

@goingforstudying-ctrl goingforstudying-ctrl force-pushed the fix/readme-typo-whitespace branch from 03113ec to 6286799 Compare May 2, 2026 12:04
@goingforstudying-ctrl
Copy link
Copy Markdown
Contributor Author

Hi etcd maintainers! 👋

Following up on this small README fix that removes extra whitespace in the image credit line. It's been about 10 days since opening.

The change is minimal and purely cosmetic — happy to adjust if needed. Let me know if there's anything I can do to help get this merged.

Thanks!

@goingforstudying-ctrl
Copy link
Copy Markdown
Contributor Author

Hi etcd maintainers! 👋

Following up on this small README whitespace fix. The k8s-ci-robot is waiting for an /ok-to-test command from an org member to run the full CI suite.

The change is minimal (removes extra whitespace in the image credit line) and the CodeQL check already passes. Could someone please trigger the tests when you have a moment?

Happy to make any adjustments if needed. Thanks!

@goingforstudying-ctrl
Copy link
Copy Markdown
Contributor Author

Hi etcd maintainers! 👋

Following up on this small README whitespace fix. The k8s-ci-robot is waiting for an etcd-io member to review and approve.

This is a minimal, safe change that removes extra whitespace in the README image credit line. All checks (CodeQL, Analyze, DCO) have passed.

Please let me know if anything else is needed. Happy to make adjustments!

@goingforstudying-ctrl
Copy link
Copy Markdown
Contributor Author

Hi etcd maintainers! 👋

Following up on this small README whitespace fix. It's been 12 days since opening and the PR is still waiting for an /ok-to-test command from an org member to run the full CI suite.

The change is minimal — removes extra whitespace in the README image credit line. All existing checks (CodeQL, Analyze, DCO) pass successfully.

Please let me know if anything else is needed. Happy to rebase or make adjustments!

Thanks for your time.

@goingforstudying-ctrl
Copy link
Copy Markdown
Contributor Author

Hi maintainers! Just a gentle ping on this very minor README whitespace fix. All checks (CodeQL, Analyze, DCO) are green. Would appreciate a review when you have a moment. Happy to make any adjustments if needed!

@goingforstudying-ctrl goingforstudying-ctrl force-pushed the fix/readme-typo-whitespace branch from 6286799 to cd5c56c Compare May 6, 2026 12:10
Removes the extra space between 'to' and 'xkcd.com/2347'.

Fixes etcd-io#21643

Signed-off-by: goingforstudying-ctrl <258847353+goingforstudying-ctrl@users.noreply.github.com>
@goingforstudying-ctrl goingforstudying-ctrl force-pushed the fix/readme-typo-whitespace branch from cd5c56c to a87ce87 Compare May 6, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

clientv3: watch shutdown may log "retrying of unary invoker failed" / "getToken failed" on expected client.Close() cancellation

2 participants