Update kubernetes patches used in etcd-k8s coverage tests#21716
Update kubernetes patches used in etcd-k8s coverage tests#21716serathius merged 1 commit intoetcd-io:mainfrom
Conversation
Signed-off-by: Aleksander Mistewicz <amistewicz@google.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 28 files with indirect coverage changes @@ Coverage Diff @@
## main #21716 +/- ##
==========================================
- Coverage 70.29% 70.27% -0.03%
==========================================
Files 426 426
Lines 35139 35139
==========================================
- Hits 24702 24694 -8
- Misses 9043 9048 +5
- Partials 1394 1397 +3 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AwesomePatrol, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
It seems like a maintenance burden to constantly update these. Have we considered upstreaming some of patches as config options? |
Yes, it was considered. We decided to wait and observe how much burden it actually is. I expected one CL per year, but apparently it is much more. Still, it adds up to 3x (5m my time, 5m reviewer time) ~ 30m so far which is much less than O(1h) required to go through kubernetes review pipeline |
Same as #21445 before
First seen in: https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/ci-etcd-k8s-coverage-amd64/2051621068765925376
/cc @serathius