Open
Conversation
Contributor
EvanBacon
commented
Mar 13, 2026
EvanBacon
commented
- Make it a bit easier for agent to understand the default structure of tabs / stack and how to use tabs.
- This adds an extra search screen which is hidden by default so the agent can decide to enable it or not. The screen helps indicate how multiple tabs with shared routes should work.
Introduce a platform-aware tab layout and a search feature: move index into a new (index,search) route group, add a temporary group layout and a search screen, and update the root _layout to render WebTabs on web and NativeTabs on native (with icons and hidden/search-specific behavior). Add use-search hook to manage the header search bar state and callbacks (returns the current query). Files added/changed: new (index,search)/_layout.tsx, (index,search)/search.tsx, src/hooks/use-search.tsx; index.tsx renamed into the new group; src/app/_layout.tsx updated to use ThemeProvider with conditional tab implementations.
| const navigation = useNavigation(); | ||
| useEffect(() => { | ||
| navigation.setOptions({ | ||
| headerShown: true, |
Contributor
There was a problem hiding this comment.
Is this iOS limitation? With the liquid glass the top bar shows and hides funny when interacting with the search.
Contributor
There was a problem hiding this comment.
Actually it's just the template where it looks a bit strange, in apps with content it's good.
Contributor
|
It's unfortunate that the initial screen won't be clean without the tabs, but I think it's worth it to avoid issues with the tabs impl by the agent. |
krystofwoldrich
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.