fix: handle two busboy error events#1296
Conversation
|
@UlisesGascon @LinusU Please take a look, when you have a chance. Thanks. |
|
Could you duplicate the test into a new one, instead of modifying the current one, so that we are sure that the previous single error is also handled? 🙏 |
@LinusU Done, please take a look. |
|
@UlisesGascon @LinusU Please take a look, when you have a chance. Thanks. |
|
Not sure why the CI pipeline was not triggered 🤔 |
|
@UlisesGascon see #1302 |
|
@UlisesGascon @LinusU Are the CI failures blockers to this PR? The tests are passing on supported Node.js versions. |
|
this looks good, but we are pulling in this fix as part of another PR. I will update when that gets merged. thank you! |
|
resolved via 2c8505f thanks everyone! |
This PR enables
multerto handle two out-of-band error events frombusboy; it does this by replacingprocess.nextTick(which happens too soon after the first error event) withsetImmediate.I don't know if this fix will handle more than two, but I also don't think
busboywill ever emit more than two.This is a follow-up to #1177.
Resolves #1176.