Rename internal errorOccured -> errorOccurred in make-middleware#1393
Open
SAY-5 wants to merge 1 commit intoexpressjs:mainfrom
Open
Rename internal errorOccured -> errorOccurred in make-middleware#1393SAY-5 wants to merge 1 commit intoexpressjs:mainfrom
SAY-5 wants to merge 1 commit intoexpressjs:mainfrom
Conversation
The middleware kept a one-shot 'has the upload errored?' flag named errorOccured (5 references in lib/make-middleware.js). The variable is private to the closure, so the rename is invisible to consumers but removes a small spelling mistake from a 12k-star project. All 72 mocha tests pass and 'standard' lint stays clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/make-middleware.jskeeps a one-shot 'has the upload errored?' flag namederrorOccured(5 references). The variable is private to the closure that builds the middleware so the rename is invisible to consumers, but it removes a spelling mistake from a high-traffic project.Verification:
npm test— all 72 mocha tests passnpm run lint(standard) — cleanSource verified against current
main.