Merged
Conversation
Copilot
AI
changed the title
[WIP] Make Approle name configurable for vault connection
Make AppRole mount point configurable
Feb 9, 2026
fajfer
reviewed
Feb 9, 2026
Comment on lines
+178
to
+179
| logger.warning( | ||
| "Deprecated: 'default_severity' in vault config. Use 'severity' instead." | ||
| ) | ||
| logger.warning("Deprecated: 'default_severity' in vault config. Use 'severity' instead.") |
Owner
There was a problem hiding this comment.
Don't do deprecation warnings at this point. We're not at version 1.x.y yet
| logger.warning( | ||
| "Deprecated: top-level 'engines' array. Move engine configs into vaults[].engines instead." | ||
| ) | ||
| logger.warning("Deprecated: top-level 'engines' array. Move engine configs into vaults[].engines instead.") |
Owner
There was a problem hiding this comment.
Don't do deprecation warnings at this point. We're not at version 1.x.y yet
- Add approle_mount_point field to VaultConfig with default "approle" - Update VaultIntegration to accept and use approle_mount_point parameter - Pass mount_point to hvac's auth.approle.login() method - Add tests for default and custom mount point configurations - Update config.example.yaml with documentation for the new field
fajfer
force-pushed
the
copilot/make-approle-name-configurable
branch
from
4391840 to
ff57bdb
Compare
Owner
|
TODO: update dev-setup.py to already set this up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AppRole authentication path was hardcoded to
approle, causing 403 errors when Vault instances used custom mount points (e.g.,auth/my-approle/login).Changes
approle_mount_pointfield toVaultConfig(default:"approle")mount_pointparameter tohvac.Client.auth.approle.login()config.example.yamlwith usage exampleUsage
Backward compatible - existing configs work unchanged.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.