refactor: customer contact doctypes#3045
refactor: customer contact doctypes#3045RitvikSardana wants to merge 41 commits intofrappe:developfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #3045 +/- ##
===========================================
+ Coverage 57.17% 57.23% +0.05%
===========================================
Files 128 119 -9
Lines 6167 6617 +450
===========================================
+ Hits 3526 3787 +261
- Misses 2641 2830 +189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@RitvikSardana Hello, could you please explain why you are breaking the integration with Erpnext by not using standard “Customer” DocType? What is the use case of having two different Doctypes related to the same customer data? Thank you! |
|
@RitvikSardana The pr is exactly what we need. Are we actively working on this? |
|
@michal-bee In future we are planning to bundle ERPNext with Helpdesk and we will merge HD Customer with Customer doctype then. |
|
Don't let this PR die! |
Also renames custom_customer to customer
remove email domain linking & hd_customer custom list view perm
638c7de to
073b60e
Compare
Tasks:
closes: #2458
depends-on: frappe/frappe#37561, frappe/frappe#38827, frappe/frappe#38751
depends-on: frappe/frappe-ui#628