feat: make all user-facing strings translatable#3155
Open
fproldan wants to merge 1 commit intofrappe:developfrom
Open
feat: make all user-facing strings translatable#3155fproldan wants to merge 1 commit intofrappe:developfrom
fproldan wants to merge 1 commit intofrappe:developfrom
Conversation
fproldan
commented
Mar 31, 2026
fproldan
commented
- Python: wrap all frappe.throw() messages with _(), fix f-string anti-patterns
- Vue/TS: wrap all toast, label, placeholder, dialog strings with __()
- Fix template literal anti-patterns: convert __(template) to __('string', [var])
- Add missing import { __ } from '@/translation' across 30+ files
- Wrap operator labels, column headers, dropdown labels, validation messages
- Files updated: auth.py, assignment_rule.py, hd_ticket_comment.py, hd_ticket_status.py, hd_desk_account_request.py (Python) 40 Vue/TS components including conditions-filter, frappe-ui, Settings, telephony, ticket, knowledge-base pages
- Python: wrap all frappe.throw() messages with _(), fix f-string anti-patterns
- Vue/TS: wrap all toast, label, placeholder, dialog strings with __()
- Fix template literal anti-patterns: convert __(template) to __('string', [var])
- Add missing import { __ } from '@/translation' across 30+ files
- Wrap operator labels, column headers, dropdown labels, validation messages
- Files updated: auth.py, assignment_rule.py, hd_ticket_comment.py,
hd_ticket_status.py, hd_desk_account_request.py (Python)
40 Vue/TS components including conditions-filter, frappe-ui, Settings,
telephony, ticket, knowledge-base pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.