fix(gatsby-source-filesystem): guard against null pathname in getParsedPath#39549
Open
singhvishalkr wants to merge 2 commits into
Open
fix(gatsby-source-filesystem): guard against null pathname in getParsedPath#39549singhvishalkr wants to merge 2 commits into
singhvishalkr wants to merge 2 commits into
Conversation
…back ESLint quotes: backtick rule in this codebase requires template literals rather than single-quoted strings, so change the '' fallback in getParsedPath() to an empty template literal to satisfy yarn lint:code.
Author
|
CI update after the lint fix (commit
Happy to help debug the PnP build if it would be useful, otherwise the PR should be ready for review on the code side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #39532
getParsedPathingatsby-source-filesystemcallspath.parse(Url.parse(url).pathname)without guarding againstnull. For malformed or edge-case URL inputs whereUrl.parse(url).pathnamereturnsnull,path.parsethrows aTypeError.Fix
Added a
|| ''fallback sopath.parsealways receives a string, consistent with the TypeScript equivalent ingatsby-core-utilswhich already includes this guard.Files Changed
packages/gatsby-source-filesystem/src/utils.js-- 1 line changeRelated Issues