add small extension to get the edit on github button working#575
Open
add small extension to get the edit on github button working#575
Conversation
Member
|
I merged #577, so I think we can safely close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@santisoler: if you have a couple of minutes, I would appreciate your thoughts on this. I suspect there is a simpler way to do this. I copied what we were doing from the gpg to get it working.
Also, this is a "good enough" for now fix. Ideally we will move this content over to myst md in the near future, so there isn't a big motivation to invest a lot in cleaning up sphinx.
edit I will get the tests passing first! (hopefully with #576)