Replace document properties drawer with inline details card#1044
Merged
SachaProbo merged 1 commit intomainfrom Apr 15, 2026
Merged
Replace document properties drawer with inline details card#1044SachaProbo merged 1 commit intomainfrom
SachaProbo merged 1 commit intomainfrom
Conversation
8260654 to
48285c5
Compare
5ae3d8b to
63be166
Compare
7538197 to
bd4a0b1
Compare
Contributor
Author
|
@cubic-dev-ai review please |
Contributor
@SachaProbo I have started the AI code review. It will take a few minutes to complete. |
Contributor
There was a problem hiding this comment.
1 issue found across 10 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/console/src/pages/organizations/documents/_components/DocumentDetailsCard.tsx">
<violation number="1" location="apps/console/src/pages/organizations/documents/_components/DocumentDetailsCard.tsx:148">
P1: These form defaults are only set on first mount, so switching to another version/document can leave edit mode bound to stale values.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
4d64527 to
1f2135f
Compare
- Remove the right-side drawer and display document properties in a 3-column Card below the page header - Move status badge to the PageHeader (right-aligned, matching compliance page style) Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
1f2135f to
7a5d4c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Replaced the right-side properties drawer with an inline 3‑column details card under the header and moved the status badge into
PageHeader. Editing (title, description, type, classification, approvers) is allowed only on the latest version that isn’t pending approval; switching/opening versions keeps the current tab and avoids remounts.New Features
PageHeader(right‑aligned).Refactors
DocumentLayoutDrawer; addedDocumentDetailsCard; query useslastVersionvia@connectionto compute editability.Outletcontext and forms to useisEditableandonDocumentUpdated; metadata/content updates refresh layout without remounting; editor key uses version/document ID to avoid unnecessary remounts; layout loader refetches on param changes with store‑and‑network;Suspensekeyed by document ID.Written for commit 7a5d4c8. Summary will update on new commits.