Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an internal socket structure overwrite when passing an AF_UNIX sockaddr_un struct with length > 20. Found by ChatGTP in #2646.
@Vutshi, thank you for running the AI kernel audit. I wrestled with this particular problem a couple times thinking I had finally fixed it, but never realized the big problem was that the passed sockaddr_len was indexing a non-zero offset of sun_path within the sockaddr_un struct. This should finally fix the memory corruption errors I had been seeing but didn't actually finally fix.
The ChatGPT proposed fix also includes a bit more argument validation as well.
Tested by running Nano-X, which uses UNIX named pipes, which exercises this code. To keep the task structure small, the max string length of named pipes (UNIX_PATH_MAX) remains at 20 including NUL (e.g. /tmp/nxsock), but is now more firmly checked and corruption potential removed.
Currently unused regression tests included in elkscmd/test/syscall/.
Thank you!