fix: replace bare except with except Exception in analysis.py#1500
Closed
srpatcha wants to merge 2 commits intogithub:stagedfrom
Closed
fix: replace bare except with except Exception in analysis.py#1500srpatcha wants to merge 2 commits intogithub:stagedfrom
srpatcha wants to merge 2 commits intogithub:stagedfrom
Conversation
Bare except clauses catch SystemExit and KeyboardInterrupt which prevents clean process termination. Use except Exception per PEP 8.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
main, but PRs should target staged.
The main branch is auto-published from staged and should not receive direct PRs.
Please close this PR and re-open it against the staged branch.
You can change the base branch using the Edit button at the top of this PR,
or run: gh pr edit 1500 --base staged
Author
|
Closing to re-target from staged branch as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated contribution by @srpatcha.
Changes
fix: replace bare except with except Exception in analysis.py
Signed-off with GPG.