Open
Conversation
sbdevman
approved these changes
Jan 3, 2022
Collaborator
|
This uses public Colly API only, you could do it from your own package just fine, and I'm not yet convinced this is frequent enough use case to be integrated into the main code base. |
amirrmonfared
approved these changes
Apr 21, 2022
amirrmonfared
approved these changes
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for maintaining this package!
Simple scheduling mechanism to periodically start a
Collector's scraping routine. The entire schedule group can be cancelled viaStopSchedulesor cancelling theCollector.Context. When a stop is executed, all currently running schedules will finish naturally (not at once). Currently, theCollector's registered callbacks are not aware of thescheduleContextcancellation viaStopSchedules.I'm sure you will like me to tweak the implementation here.