Fix height attribute for spacer block#940
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes spacer block height attribute format to prevent display errors when using the Layout Selector component from CoBlocks. The spacer block now expects string values with units (e.g., '20px') instead of numeric values.
- Updated all spacer block height attributes from numeric values to string values with 'px' units
- Fixed compatibility issue between Go layouts and CoBlocks Layout Selector component
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| partials/layouts/home.php | Updated three spacer blocks to use string height values ('60px', '20px', '30px') |
| partials/layouts/contact.php | Updated one spacer block to use string height value ('30px') |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mtashjianjr-godaddy
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spacer block has an error when used with the Layout Selector component from CoBlocks with layouts hosted here in Go. Specifically some Home and a contact layout have spacer blocks with a numeric height number. This block actually expects to see a string value now like '20px' for example.
Tested the spacer layouts in local development environment.

Before:
After:
