Fix race condition when calling play() just right after pause() on iOS#1761
Open
xuanduc987 wants to merge 1 commit intogoldfire:masterfrom
Open
Fix race condition when calling play() just right after pause() on iOS#1761xuanduc987 wants to merge 1 commit intogoldfire:masterfrom
xuanduc987 wants to merge 1 commit intogoldfire:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue/Feature
Fix race condition when calling play() just right after pause() on iOS
On iOS, a looping sound with html5:true fails to loop intermittently.
Related Issues
Solution
Calling play() in next macro task by wrapping
playHtml5insetTimeoutReproduction/Testing
I can reproduce the bug pretty frequently with somewhat long audio file.
Breaking Changes
N/A