Fix #1303: Remove posterUrl from Video in v0.9 Angular and add to v0.10 spec#1373
Open
josemontespg wants to merge 7 commits into
Open
Fix #1303: Remove posterUrl from Video in v0.9 Angular and add to v0.10 spec#1373josemontespg wants to merge 7 commits into
josemontespg wants to merge 7 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the 'posterUrl' feature from the v0.9 Angular Video component while simultaneously adding it to the v0.10 JSON specification. The review feedback highlights several instances of unnecessary blank lines left behind after the code removal, which violate the repository's style guide regarding clean code and auto-formatting. Additionally, the reviewer noted that the component's JSDoc documentation needs to be updated to reflect the removal of the poster image feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removed support for the
posterUrlproperty in the v0.9 Angular implementation of theVideocomponent, and added it to the v0.10 specification.Why
Similar to the
placeholderproperty,posterUrlwas supported in the Angular renderer but missing from the v0.9 spec. It was removed from the v0.9 renderer for consistency. Since it maps directly to an HTML attribute and is essential for theVideocomponent, it was added to the v0.10 specification.Addresses #1303