Skip to content

Kotlin sdk treeshake common types#1395

Open
jgindin wants to merge 3 commits into
google:mainfrom
jgindin:kotlin-sdk-treeshake-common-types
Open

Kotlin sdk treeshake common types#1395
jgindin wants to merge 3 commits into
google:mainfrom
jgindin:kotlin-sdk-treeshake-common-types

Conversation

@jgindin
Copy link
Copy Markdown
Collaborator

@jgindin jgindin commented May 11, 2026 •
edited
Loading

Description

Treeshake common types schema

Port of Python SDK commit 1ea689d

Pre-launch Checklist

If you need help, consider asking for advice on the discussion board.

@jgindin jgindin requested a review from nan-yu May 11, 2026 16:23
@jgindin jgindin self-assigned this May 11, 2026
@github-project-automation github-project-automation Bot moved this to Todo in A2UI May 11, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive streaming parser for A2UI, supporting both v0.8 and v0.9 specifications. Key additions include the StreamingParser hierarchy, a SchemaInspector for heuristic component detection, and a TopologyAnalyzer for reachability analysis. The A2uiCatalog was also updated with logic to prune unused common types. Review feedback highlights several critical performance concerns in the parser implementation, such as inefficient string concatenation in buffers, frequent regex compilation during metadata sniffing, and redundant serialization when tracking yielded components.

Comment thread agent_sdks/kotlin/src/main/kotlin/com/google/a2ui/core/parser/StreamingParser.kt Outdated
Comment thread agent_sdks/kotlin/src/main/kotlin/com/google/a2ui/core/parser/StreamingParser.kt Outdated
Comment thread agent_sdks/kotlin/src/main/kotlin/com/google/a2ui/core/parser/StreamingParser.kt Outdated
Comment thread agent_sdks/kotlin/src/main/kotlin/com/google/a2ui/core/parser/StreamingParser.kt Outdated
Comment thread agent_sdks/kotlin/src/main/kotlin/com/google/a2ui/core/parser/StreamingParser.kt Outdated
@jgindin jgindin force-pushed the kotlin-sdk-treeshake-common-types branch from a7ac93c to db30a57 Compare May 12, 2026 02:44
@jgindin jgindin force-pushed the kotlin-sdk-treeshake-common-types branch 2 times, most recently from 263339c to 6a1ba9c Compare May 12, 2026 15:51
nan-yu
nan-yu reviewed May 12, 2026
View reviewed changes
Comment thread agent_sdks/kotlin/src/test/kotlin/com/google/a2ui/core/schema/CatalogPruningTest.kt
Copy link
Copy Markdown
Collaborator

@nan-yu nan-yu May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit tests should be covered by the conformance tests in catalog.yaml.

If not, we should update the conformance tests.

jgindin added 2 commits May 12, 2026 18:02
@jgindin
v0.9 streaming parser suite
6ddef51 
Implements the full incremental A2UI v0.9 streaming parser suite in
Kotlin, achieving SDK parity. Automatically incorporates critical
subsequent fixes for robust real-time topology parsing and relative
bindings.

Port of Python SDK commit 8ba982a
@jgindin
Treeshake common types schema
b29730c 
Port of Python SDK commit 1ea689d
@jgindin jgindin force-pushed the kotlin-sdk-treeshake-common-types branch from 6a1ba9c to b29730c Compare May 12, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nan-yu nan-yu nan-yu left review comments

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@jgindin jgindin

Labels

None yet

Projects

A2UI
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jgindin @nan-yu