internal/context: delete the deprecated alias layer; update all calle…#821
Draft
wolo-lab wants to merge 1 commit into
Draft
internal/context: delete the deprecated alias layer; update all calle…#821wolo-lab wants to merge 1 commit into
wolo-lab wants to merge 1 commit into
Conversation
…rs to import agent directly Sweeps the 28 importers of internal/context (alias 'icontext' or 'contextinternal') to use agent.NewX directly. The alias layer introduced in PR #1 was a transitional stage; with PR #2 (unified agent.Context interface) landed, no consumer needs internal/context any more. Mechanical changes: * `icontext.NewInvocationContext` → `agent.NewInvocationContext` (most uses) * `icontext.InvocationContextParams` → `agent.InvocationContextParams` * `icontext.NewCallbackContext` → `agent.NewCallbackContext` (2 uses) * `icontext.NewCallbackContextWithDelta` → `agent.NewCallbackContextWithDelta` (8 uses) * `icontext.NewReadonlyContext` → `agent.NewReadonlyContext` (3 uses) Per-file: 28 importer files lose their `icontext "…/internal/context"` import line. `internal/toolinternal/context_test.go` had a different alias name (`contextinternal`); also rewritten. One ad-hoc fix: `agent/remoteagent/v2/utils_test.go` had a local variable named `agent` shadowing the package name; renamed to `a` (unrelated to the sweep but exposed by it). Then deletes `internal/context/` entirely. The package no longer exists; `agent` is the single home for canonical context constructors. Verified: go build ./...; go vet ./...; go test ./...; all pass.
6882fc2 to
84284c1
Compare
4d28e77 to
b7b2b9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rs to import agent directly
Sweeps the 28 importers of internal/context (alias 'icontext' or 'contextinternal') to use agent.NewX directly. The alias layer introduced in PR #1 was a transitional stage; with PR #2 (unified agent.Context interface) landed, no consumer needs internal/context any more.
Mechanical changes:
icontext.NewInvocationContext→agent.NewInvocationContext(most uses)icontext.InvocationContextParams→agent.InvocationContextParamsicontext.NewCallbackContext→agent.NewCallbackContext(2 uses)icontext.NewCallbackContextWithDelta→agent.NewCallbackContextWithDelta(8 uses)icontext.NewReadonlyContext→agent.NewReadonlyContext(3 uses)Per-file: 28 importer files lose their
icontext "…/internal/context"import line.internal/toolinternal/context_test.gohad a different alias name (contextinternal); also rewritten.One ad-hoc fix:
agent/remoteagent/v2/utils_test.gohad a local variable namedagentshadowing the package name; renamed toa(unrelated to the sweep but exposed by it).Then deletes
internal/context/entirely. The package no longer exists;agentis the single home for canonical context constructors.Verified: go build ./...; go vet ./...; go test ./...; all pass.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
If applicable, please follow the issue templates to provide as much detail as
possible.
Problem:
A clear and concise description of what the problem is.
Solution:
A clear and concise description of what you want to happen and why you choose
this solution.
Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed go test results.
Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.
Checklist
Additional context
Add any other context or screenshots about the feature request here.