Skip to content

internal/context: delete the deprecated alias layer; update all calle…#821

Draft
wolo-lab wants to merge 1 commit into
wolo/context_unif_v2_pr2_unifyfrom
wolo/context_unif_v2_pr3_cleanup
Draft

internal/context: delete the deprecated alias layer; update all calle…#821
wolo-lab wants to merge 1 commit into
wolo/context_unif_v2_pr2_unifyfrom
wolo/context_unif_v2_pr3_cleanup

Conversation

@wolo-lab
Copy link
Copy Markdown

…rs to import agent directly

Sweeps the 28 importers of internal/context (alias 'icontext' or 'contextinternal') to use agent.NewX directly. The alias layer introduced in PR #1 was a transitional stage; with PR #2 (unified agent.Context interface) landed, no consumer needs internal/context any more.

Mechanical changes:

  • icontext.NewInvocationContextagent.NewInvocationContext (most uses)
  • icontext.InvocationContextParamsagent.InvocationContextParams
  • icontext.NewCallbackContextagent.NewCallbackContext (2 uses)
  • icontext.NewCallbackContextWithDeltaagent.NewCallbackContextWithDelta (8 uses)
  • icontext.NewReadonlyContextagent.NewReadonlyContext (3 uses)

Per-file: 28 importer files lose their icontext "…/internal/context" import line. internal/toolinternal/context_test.go had a different alias name (contextinternal); also rewritten.

One ad-hoc fix: agent/remoteagent/v2/utils_test.go had a local variable named agent shadowing the package name; renamed to a (unrelated to the sweep but exposed by it).

Then deletes internal/context/ entirely. The package no longer exists; agent is the single home for canonical context constructors.

Verified: go build ./...; go vet ./...; go test ./...; all pass.

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

  • Closes: #issue_number
  • Related: #issue_number

2. Or, if no issue exists, describe the change:

If applicable, please follow the issue templates to provide as much detail as
possible.

Problem:
A clear and concise description of what the problem is.

Solution:
A clear and concise description of what you want to happen and why you choose
this solution.

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed go test results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

…rs to import agent directly

Sweeps the 28 importers of internal/context (alias 'icontext' or
'contextinternal') to use agent.NewX directly. The alias layer
introduced in PR #1 was a transitional stage; with PR #2 (unified
agent.Context interface) landed, no consumer needs internal/context
any more.

Mechanical changes:

  * `icontext.NewInvocationContext` → `agent.NewInvocationContext` (most uses)
  * `icontext.InvocationContextParams` → `agent.InvocationContextParams`
  * `icontext.NewCallbackContext` → `agent.NewCallbackContext` (2 uses)
  * `icontext.NewCallbackContextWithDelta` → `agent.NewCallbackContextWithDelta` (8 uses)
  * `icontext.NewReadonlyContext` → `agent.NewReadonlyContext` (3 uses)

Per-file: 28 importer files lose their `icontext "…/internal/context"`
import line. `internal/toolinternal/context_test.go` had a different
alias name (`contextinternal`); also rewritten.

One ad-hoc fix: `agent/remoteagent/v2/utils_test.go` had a local
variable named `agent` shadowing the package name; renamed to `a`
(unrelated to the sweep but exposed by it).

Then deletes `internal/context/` entirely. The package no longer
exists; `agent` is the single home for canonical context constructors.

Verified: go build ./...; go vet ./...; go test ./...; all pass.
@wolo-lab wolo-lab force-pushed the wolo/context_unif_v2_pr2_unify branch from 6882fc2 to 84284c1 Compare May 12, 2026 20:18
@wolo-lab wolo-lab force-pushed the wolo/context_unif_v2_pr3_cleanup branch from 4d28e77 to b7b2b9d Compare May 12, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant