feat(poc): limited POC of a typesafe RequestContext alternative#4930
Draft
mregulski-gravitee wants to merge 1 commit into
Draft
feat(poc): limited POC of a typesafe RequestContext alternative#4930mregulski-gravitee wants to merge 1 commit into
mregulski-gravitee wants to merge 1 commit into
Conversation
mregulski-gravitee
force-pushed
the
feat/AM-2753-unify-context
branch
from
16eae1d to
87a03c5
Compare
mregulski-gravitee
changed the title
leleueri
reviewed
Oct 7, 2024
Comment on lines
+26
to
+31
| if (context.get("_am") instanceof AmContext amContext) { | ||
| handle(amContext); | ||
| } else { | ||
| AmContext.prepare(context); | ||
| handle(context); | ||
| } |
Contributor
There was a problem hiding this comment.
thought: maybe we can always do handle(AmContext.from(context)) and delegate the build logic to AmContext itself to avoid recursive call ?
Contributor
Author
There was a problem hiding this comment.
hmm prepare(RoutingContext) re-uses the AmContext if it already exists so that would be a better way
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🆔 Reference related issue.
AM-2753
✏️ A description of the changes proposed in the pull request
writeup