fix: let users pass page HRID for plan general condition#16339
Merged
fix: let users pass page HRID for plan general condition#16339
Conversation
kamiiiel
force-pushed
the
gko-2609-general-condition
branch
from
e6bdec5 to
7fc6cc4
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the ImportApiCRDUseCase to persist pages before the API update, ensuring that plan general-condition references are resolvable. It also updates ApiServiceImpl to use setReferenceId and setReferenceType for plans. The review feedback suggests that while moving page creation earlier is necessary, the deletion of removed pages should still occur after the API update to maintain data consistency and avoid reference violations.
kamiiiel
force-pushed
the
gko-2609-general-condition
branch
from
7fc6cc4 to
bf5f1a9
Compare
kamiiiel
added
apply-on-4-7-x
apply-on-4-8-x
apply-on-4-9-x
apply-on-4-10-x
apply-on-4-11-x
kamiiiel
force-pushed
the
gko-2609-general-condition
branch
2 times, most recently
from
4930e42 to
ef9240e
Compare
kamiiiel
force-pushed
the
gko-2609-general-condition
branch
from
ef9240e to
1d5c055
Compare
a-cordier
reviewed
Apr 14, 2026
Member
a-cordier
left a comment
a-cordier
left a comment
There was a problem hiding this comment.
can we do a quick test of the fix with TF ?
benoitgravitee
approved these changes
Apr 20, 2026
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://gravitee.atlassian.net/browse/GKO-2803