Fix face masking for invalid frames

[duyua9]

Summary

• Return an empty mask when face_masking.create_face_mask() receives None, an object without shape, or a 1D frame.
• Add focused unit coverage with lightweight fakes so the invalid-frame path does not import heavy runtime dependencies.

Validation

• python3 -m unittest tests/test_face_masking_mask.py
• python3 -m py_compile modules/processors/frame/face_masking.py tests/test_face_masking_mask.py
• git diff --check
• bash /Users/ming/.openclaw/skills/code-change-delivery-contract/scripts/scan_delivery_blockers.sh

Summary by Sourcery

Handle invalid frame inputs in face masking and add focused tests for these edge cases.

Bug Fixes:

• Return an empty mask when face masking is invoked with None, objects lacking a shape attribute, or 1D frames to avoid errors on invalid input.

Tests:

• Add lightweight unit tests for create_face_mask that validate behavior for None, non-array, and 1D frame inputs without importing heavy runtime dependencies.

[sourcery-ai]

Reviewer's Guide

Adds defensive handling in face_masking.create_face_mask to return an empty uint8 mask for invalid or degenerate frames, and introduces lightweight, isolated unit tests using faked numpy/cv2/modules to cover these edge cases without heavy runtime dependencies.

File-Level Changes

Change	Details	Files
Defensively handle invalid or degenerate frame inputs in face mask creation by returning an empty uint8 mask.	Add a guard in the face mask creation function to check for None frames, missing shape attribute, or frames with fewer than two dimensions. Return a zero-sized uint8 mask instead of proceeding with mask generation when the frame is invalid. Preserve existing behavior for valid 2D+ frames by leaving the rest of the function unchanged.	modules/processors/frame/face_masking.py
Introduce focused unit tests for create_face_mask invalid-frame behavior using lightweight fakes to avoid heavy dependencies.	Create a helper that loads the face_masking module with faked numpy, cv2, globals, gpu_processing, and typing modules injected via sys.modules and mock.patch.dict. Define a minimal FakeArray and fake numpy.zeros/uint8 to validate that create_face_mask returns a zero-sized mask of the correct dtype. Add tests covering None frames, frames without a shape attribute, and 1D frames, all asserting the empty-mask behavior. Ensure the test module is executable directly with unittest.main().	tests/test_face_masking_mask.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}