pre-commit: enable shfmt and shellcheck (#9021)

Author: alexreinking

.github/workflows/testing-ecosystem.yml

@@ -34,7 +34,7 @@ jobs:
           wget -qO- https://apt.llvm.org/llvm-snapshot.gpg.key | sudo tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc
           echo "deb http://apt.llvm.org/$(lsb_release -cs)/ llvm-toolchain-$(lsb_release -cs)-${LLVM_VERSION} main" | \
             sudo tee "/etc/apt/sources.list.d/llvm-${LLVM_VERSION}.list"
-          
+
           # Get everything else from upstream Ubuntu
           sudo apt-get update && sudo apt-get install -y \
             "clang-${LLVM_VERSION}" \
@@ -48,7 +48,7 @@ jobs:
             "liblld-${LLVM_VERSION}-dev" \
             "lld-${LLVM_VERSION}" \
             "llvm-${LLVM_VERSION}-dev" \
-            pybind11-dev 
+            pybind11-dev
 
       - name: Check CMake configures
         run: cmake --preset ubuntu-release -DHalide_LLVM_ROOT="/usr/lib/llvm-${LLVM_VERSION}"

.pre-commit-config.yaml

@@ -58,6 +58,19 @@ repos:
       - id: ruff-check
       - id: ruff-format
 
+  - repo: https://github.com/shellcheck-py/shellcheck-py
+    rev: v0.11.0.1
+    hooks:
+      - id: shellcheck
+        exclude: ^apps/HelloAndroid.*/gradlew$
+
+  - repo: https://github.com/maxwinterstein/shfmt-py
+    rev: v3.12.0.1
+    hooks:
+      - id: shfmt
+        args: [ -i, "4", -ci, -s, -w ]
+        exclude: ^apps/HelloAndroid.*/gradlew$
+
   - repo: https://github.com/ComPWA/taplo-pre-commit
     rev: v0.9.3
     hooks:

CMakePresets.json

@@ -124,13 +124,19 @@
     },
     {
       "name": "ubuntu-debug",
-      "inherits": ["ubuntu", "debug"],
+      "inherits": [
+        "ubuntu",
+        "debug"
+      ],
       "displayName": "Debug (Ubuntu)",
       "description": "Debug build for a single-config generator, Ubuntu dependencies"
     },
     {
       "name": "ubuntu-release",
-      "inherits": ["ubuntu", "release"],
+      "inherits": [
+        "ubuntu",
+        "release"
+      ],
       "displayName": "Release (Ubuntu)",
       "description": "Release build for a single-config generator, Ubuntu dependencies"
     },

apps/HelloAndroid/build.sh

@@ -8,13 +8,13 @@ c++ jni/hello_generator.cpp ../../tools/GenGen.cpp \
     -L ../../bin -lHalide -ldl -lpthread -lz \
     -o bin/hello_generator
 
-for archs in arm-32-android,armeabi arm-32-android-armv7s,armeabi-v7a arm-64-android,arm64-v8a x86-64-android-sse41,x86_64 x86-32-android,x86 ; do
+for archs in arm-32-android,armeabi arm-32-android-armv7s,armeabi-v7a arm-64-android,arm64-v8a x86-64-android-sse41,x86_64 x86-32-android,x86; do
     IFS=,
     set $archs
     HL_TARGET=$1
     ANDROID_ABI=$2
-    mkdir -p bin/$ANDROID_ABI
-    ./bin/hello_generator -g hello -o bin/$ANDROID_ABI target=$HL_TARGET
+    mkdir -p bin/"$ANDROID_ABI"
+    ./bin/hello_generator -g hello -o bin/"$ANDROID_ABI" target="$HL_TARGET"
     unset IFS
 done
 

apps/HelloAndroidCamera2/build.sh

@@ -20,18 +20,18 @@ c++ jni/deinterleave_generator.cpp ../../tools/GenGen.cpp \
     -L ../../bin -lHalide -ldl -lpthread -lz \
     -o bin/deinterleave_generator
 
-for archs in arm-32-android,armeabi arm-32-android-armv7s,armeabi-v7a arm-64-android,arm64-v8a x86-64-android-sse41,x86_64 x86-32-android,x86 ; do
+for archs in arm-32-android,armeabi arm-32-android-armv7s,armeabi-v7a arm-64-android,arm64-v8a x86-64-android-sse41,x86_64 x86-32-android,x86; do
     IFS=,
     set $archs
     HL_TARGET=$1
     ANDROID_ABI=$2
-    mkdir -p bin/$ANDROID_ABI
-    ./bin/edge_detect_generator -g edge_detect -o bin/$ANDROID_ABI target=$HL_TARGET
-    ./bin/deinterleave_generator -g deinterleave -o bin/$ANDROID_ABI target=$HL_TARGET
+    mkdir -p bin/"$ANDROID_ABI"
+    ./bin/edge_detect_generator -g edge_detect -o bin/"$ANDROID_ABI" target="$HL_TARGET"
+    ./bin/deinterleave_generator -g deinterleave -o bin/"$ANDROID_ABI" target="$HL_TARGET"
     unset IFS
 done
 
-${ANDROID_NDK_HOME}/ndk-build NDK_GEN_OUT=./bin/gen NDK_LIBS_OUT=./bin/lib NDK_OUT=./bin/obj
+"${ANDROID_NDK_HOME}"/ndk-build NDK_GEN_OUT=./bin/gen NDK_LIBS_OUT=./bin/lib NDK_OUT=./bin/obj
 ant debug
 adb install -r bin/HelloAndroidCamera2-debug.apk
 adb logcat

apps/HelloBaremetal/cmake-external_project/build.sh

@@ -4,7 +4,7 @@ set -eo pipefail
 # Prerequisite :
 #     Halide is installed system-wide in your host machine or discoverable via CMAKE_PREFIX_PATH
 
-cd "$(dirname ${BASH_SOURCE[0]})"
+cd "$(dirname "${BASH_SOURCE[0]}")"
 readonly TOOLCHAIN_FILE="${PWD}/../cmake/toolchain.noos-arm32-sample.cmake"
 
 rm -rf build

apps/HelloBaremetal/cmake-external_project/run.sh

@@ -1,4 +1,4 @@
 #!/bin/bash
 
-cd "$(dirname ${BASH_SOURCE[0]})"
+cd "$(dirname "${BASH_SOURCE[0]}")" || exit
 ../run_baremetal.sh build/bin/add_filter ../../images/gray_small.pgm 16 build/out.pgm

apps/HelloBaremetal/cmake-super_build/build.sh

@@ -4,7 +4,7 @@ set -eo pipefail
 # Prerequisite :
 #     Halide is installed system-wide in your host machine or discoverable via CMAKE_PREFIX_PATH
 
-cd "$(dirname ${BASH_SOURCE[0]})"
+cd "$(dirname "${BASH_SOURCE[0]}")"
 readonly TOOLCHAIN_FILE="${PWD}/../cmake/toolchain.noos-arm32-sample.cmake"
 
 rm -rf build

apps/HelloBaremetal/cmake-super_build/run.sh

@@ -1,4 +1,4 @@
 #!/bin/bash
 
-cd "$(dirname ${BASH_SOURCE[0]})"
+cd "$(dirname "${BASH_SOURCE[0]}")" || exit
 ../run_baremetal.sh build/bin/add_filter ../../images/gray_small.pgm 16 build/out.pgm

apps/HelloBaremetal/cmake-twice/build.sh

@@ -4,7 +4,7 @@ set -eo pipefail
 # Prerequisite :
 #     Halide is installed system-wide in your host machine or discoverable via CMAKE_PREFIX_PATH
 
-cd "$(dirname ${BASH_SOURCE[0]})"
+cd "$(dirname "${BASH_SOURCE[0]}")"
 readonly TOOLCHAIN_FILE="${PWD}/../cmake/toolchain.noos-arm32-sample.cmake"
 readonly GEN_PACKAGE="HelloBaremetal-add_generator"
 
@@ -22,8 +22,8 @@ cmake --build build-host/ --target "${GEN_PACKAGE}"
 # Build application with cross compiler,
 # where the generator executable built in Step 1 is just imported and called
 cmake -S . -B build-target \
-	    -DCMAKE_TOOLCHAIN_FILE="${TOOLCHAIN_FILE}" \
-	    -DGEN_PACKAGE="${GEN_PACKAGE}" \
-	    -D${GEN_PACKAGE}_ROOT:FILEPATH=build-host
+    -DCMAKE_TOOLCHAIN_FILE="${TOOLCHAIN_FILE}" \
+    -DGEN_PACKAGE="${GEN_PACKAGE}" \
+    -D${GEN_PACKAGE}_ROOT:FILEPATH=build-host
 
 cmake --build build-target/