Improve the comments in IR.h to give more detail on intended semantics#9106
Merged
Improve the comments in IR.h to give more detail on intended semantics#9106
Conversation
alexreinking
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Halide IR semantics are unclear, particularly when it comes to arithmetic, have some outstanding issues (e.g. see #9105). They also differ from C, so intuition ported from other languages doesn't work. This PR adds more comments to IR.h to clarify what the intended semantics are and what the current state of things is.
It's looking like its critical these are accurately understood by LLMs in particular, so I tested it by getting Opus to grill Haiku on Halide semantics with me tweaking the comments until Haiku understood at least as well as Opus.