Added type synonym for error in mimeUnrender and ResultStream#1053
Open
jhmcstanton wants to merge 1 commit intohaskell-servant:masterfrom
Open
Added type synonym for error in mimeUnrender and ResultStream#1053jhmcstanton wants to merge 1 commit intohaskell-servant:masterfrom
jhmcstanton wants to merge 1 commit intohaskell-servant:masterfrom
Conversation
Swapped String error to type synonym Resolves haskell-servant#999
Contributor
|
Hi @jhmcstanton! Thank you very much for this PR. In concertation with @gdeest and @akhesaCaro, we have come to the conclusion that this type ought to be a newtype, so that we can better restrict the scope of possible values. As an aside, do you think that the entirety of Shakespear's work in Mandarin could be a valid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just used one of the type names suggested in the issue, is that name still OK?