Update pre-commit hooks and update dev docs#487
Merged
Conversation
- Add .pre-commit-config.yaml with three hooks:
- prettier: auto-formats staged frontend/src/ files
- eslint: lints staged frontend/src/ files
- ruff (v0.15.5): checks Python syntax errors and undefined names
(E9, F63, F7, F821) in montage/
- Add pyproject.toml with ruff line-length config
- Update dev.md:
- Add OAuth setup section explaining both modes (debug bypass vs
real OAuth) with step-by-step registration instructions
- Link to MediaWiki OAuth developer guide and Toolforge docs
- Add pre-commit hooks setup section
- Add CI section with local check commands
- Add lint:check and format:check to frontend commands list
- Fix Node.js version requirement (v16 -> v20)
- Remove .env from project structure (gitignored file)
- Update README.md:
- Add CI badge
- Add Development section linking to dev.md
- Replace outdated tox instructions with Docker-based test command
- Add Deployment section linking to deployment.md
- Fix view_jurors -> view_juror typo in rendered_admin.py (ruff F821
caught this: route referenced view_juror but function was named
view_jurors)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #407
Add .pre-commit-config.yaml with three hooks:
Add pyproject.toml with ruff line-length config
Update dev.md:
Update README.md:
Fix view_jurors -> view_juror typo in rendered_admin.py (ruff F821 caught this: route referenced view_juror but function was named view_jurors)