POC : Make Standard Triggers natively work like DataDriven Triggers#443
Open
jshaughn wants to merge 1 commit intohawkular:masterfrom
Open
POC : Make Standard Triggers natively work like DataDriven Triggers#443jshaughn wants to merge 1 commit intohawkular:masterfrom
jshaughn wants to merge 1 commit intohawkular:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do Not Merge until reviewed and dicussed. PR opened for review and to keep in sync with master.
I spent a few days investigating this somewhat major change to trigger semantics. In short it merges the data-driven group trigger feature into standard triggers. Put another way, it lets a single trigger handle data/events from N sources. The big difference is that it does it without using a backing group trigger. It's not totally seamless, there are some behavioral differences but I think the benefits justify the changes.
Here is a diagram of the approach: