Skip to content

progress bar optional manual control#8021

Open
AnkitAhlawat7742 wants to merge 3 commits intohuggingface:mainfrom
AnkitAhlawat7742:feat/7939-progress_bar_option
Open

progress bar optional manual control#8021
AnkitAhlawat7742 wants to merge 3 commits intohuggingface:mainfrom
AnkitAhlawat7742:feat/7939-progress_bar_option

Conversation

@AnkitAhlawat7742
Copy link
Copy Markdown
Contributor

Fix: #7939

Summary

The default behavior for the progress bar has been adjusted based on dataset size. It remains enabled for small datasets and is automatically disabled for larger datasets to improve performance. Users retain full control and can explicitly enable or disable the progress bar using the progress_bar parameter.

Changes

Modified the logic to disable the progress bar when the number of files exceeds 16.

@AnkitAhlawat7742
Copy link
Copy Markdown
Contributor Author

Hi @lhoestq ,
Can you please trigger the CI CD pipeline ?

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@AnkitAhlawat7742
Copy link
Copy Markdown
Contributor Author

@lhoestq I have applied the required Ruff formatting changes in the load.py file.
Could you please trigger the CI/CD pipeline again?

@AnkitAhlawat7742
Copy link
Copy Markdown
Contributor Author

HI @lhoestq ,
Just a gentle reminder to please trigger the CI/CD pipeline for this PR..!!

@AnkitAhlawat7742
Copy link
Copy Markdown
Contributor Author

HI @julien-c ,
can you please trigger the the CI/CD pipeline for this PR.

@AnkitAhlawat7742
Copy link
Copy Markdown
Contributor Author

Hi @albertvillanova ,
Could you please trigger the CI/CD pipeline?, i can see it is pending from long time
Thanks

@lhoestq
Copy link
Copy Markdown
Member

lhoestq commented Apr 7, 2026

I don't think we want to add more arguments to this method.
Progress bars can already be disabled like this

from datasets.utils import disable_progress_bars

disable_progress_bars()

@AnkitAhlawat7742
Copy link
Copy Markdown
Contributor Author

AnkitAhlawat7742 commented Apr 8, 2026

Hey @lhoestq ,
My intention was to provide more fine-grained control at the method level, particularly for multiprocessing scenarios where multiple progress bars can clutter the logs. This would give users the flexibility to explicitly enable or disable the progress bar as needed,which aligns with the concern raised in the issue #7939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

datasets.load_from_disk progress bar optional manual control

3 participants