fix(gamepad): Gamepad on macos often does not need fallback.#3420
Open
Mxbonn wants to merge 2 commits intohuggingface:mainfrom
Open
fix(gamepad): Gamepad on macos often does not need fallback.#3420Mxbonn wants to merge 2 commits intohuggingface:mainfrom
Mxbonn wants to merge 2 commits intohuggingface:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts macOS gamepad handling so LeRobot doesn’t automatically switch all macOS users to the HIDAPI-based controller, keeping the default pygame controller and making HIDAPI an opt-in fallback.
Changes:
- Adds a
hidapi_fallbackflag toGamepadTeleopto control whetherGamepadControllerHIDorGamepadControlleris used. - Emits a macOS warning when not using the HIDAPI fallback to help users troubleshoot controller detection issues.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GamepadControllerHIDandGamepadControllerare not fully compatible. E.g. they have different joystick behaviour, it seems likeGamepadControllerHIDis mainly created as a fallback for the Logitech RumblePad 2 on macos (based on the comments).From my own testing, the original Gamepad controller works fine on macos for the Xbox controller, thus it seems to make more sense to add the fallback as an explicit option instead of swapping it for every macos user.