fix: use <= instead of < for timestamp tolerance comparison in video_utils#3423
Open
walle250ai wants to merge 1 commit intohuggingface:mainfrom
Open
fix: use <= instead of < for timestamp tolerance comparison in video_utils#3423walle250ai wants to merge 1 commit intohuggingface:mainfrom
walle250ai wants to merge 1 commit intohuggingface:mainfrom
Conversation
github-actions
Bot
added
the
dataset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix floating point precision issue in decode_video_frames_torchvision
and decode_video_frames_torchcodec functions.
Changed
<to<=in tolerance comparison to be consistent withfeature_utils.py and avoid incorrectly rejecting frames when min_
exactly equals tolerance_s due to floating point precision.