docs + fix: sync SKILL.md, normalize linearDocument ref, correct changeset#208
docs + fix: sync SKILL.md, normalize linearDocument ref, correct changeset#208s-adamantine merged 2 commits intomainfrom
Conversation
PR #174 added longDescription and visibility to app.certified.actor.organization and updated the README overview row, but the matching row in SKILL.md was not updated. AGENTS.md requires both files stay in sync so AI agents consuming the skill see the full set of documented fields. Bring the SKILL.md Certified row in line with README.md (legal structure, URLs, location, founding date, optional long description, discoverability visibility). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughUpdated documentation and schema for the Organization certified lexicon: SKILL.md table row for Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🦋 Changeset detectedLatest commit: 89d1bd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Two follow-ups to PR #174: 1. Drop the redundant `#main` suffix from the `longDescription` union's Leaflet ref in `app.certified.actor.organization`, so it matches the bare `pub.leaflet.pages.linearDocument` form already used on activity, collection, and attachment after the cleanup in 06fce2c. PR #174 was rebased onto that cleanup but re-introduced `#main` for the new organization field. Purely a ref-string normalization — the target def is identical. 2. Update the unreleased changeset description to describe the actual 3-way union (inline string / embedded Leaflet linear document / strongRef), not a 2-way union, so the v0.12.0 CHANGELOG entry is accurate. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
LGTM — docs sync plus a ref normalization (drops #main to match the other lexicons that reference linearDocument).
Extended reasoning...
Overview
Small, mostly-documentation PR that (1) syncs the SKILL.md Certified lexicons overview row for Organization with README.md by listing the new foundedDate, longDescription, and visibility fields, (2) adds a patch changeset for the SKILL.md sync, (3) tightens the existing minor changeset's wording, and (4) normalizes the longDescription union ref in lexicons/app/certified/actor/organization.json from pub.leaflet.pages.linearDocument#main to pub.leaflet.pages.linearDocument.
Security risks
None. No auth, crypto, or permission logic is touched. The lexicon ref normalization only affects schema validation expectations.
Level of scrutiny
Low. SKILL.md and changeset edits are user-facing docs but purely textual. The one lexicon edit is a mechanical consistency fix: collection.json, context/attachment.json, and claim/activity.json already reference pub.leaflet.pages.linearDocument without the #main suffix, so this brings organization.json in line with the established pattern in this repo.
Other factors
No bugs were flagged by the bug hunter. CodeRabbit's pre-merge checks all pass. The SKILL.md change simply mirrors content that already exists in README.md per the AGENTS.md sync requirement.
Follow-ups to the freshly-merged PR #174 (now on
main).Summary
Sync SKILL.md with README. The Organization row in
.agents/skills/building-with-hypercerts-lexicons/SKILL.mdwas not updated alongsideREADME.md:273, violating AGENTS.md:241–248 which requires both files stay in sync when either references a lexicon. Downstream AI agents installing the skill vianpx skills add hypercerts-org/hypercerts-lexiconwere seeing a stale overview row.Normalize
longDescriptionref. In PR NON-BREAKING: add optional longDescription and visibility fields to organization #174 the new Leaflet variant onapp.certified.actor.organizationwas added aspub.leaflet.pages.linearDocument#main, but the peer lexicons (activity, collection, attachment) already use the barepub.leaflet.pages.linearDocumentform after cleanup commit06fce2c. PR NON-BREAKING: add optional longDescription and visibility fields to organization #174 was rebased onto that cleanup but re-introduced the redundant#main. Dropping it restores consistency at the ref-string level. Purely a syntactic normalization — the target def is unchanged.Fix unreleased changeset wording.
.changeset/add-organization-page-and-visibility.mddescribedlongDescriptionas a 2-way union, but the actual schema has three variants (inline string / embedded Leaflet linear document / strongRef). Rewrote the description so the v0.12.0 CHANGELOG entry accurately reflects the schema and the "consistency with activity, collection, attachment" claim is truthful after fix Hypercert Sale Lexicon #2.Test plan
npm run check(validate + typecheck + build + 135 tests pass)🤖 Generated with Claude Code